-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for backup
in azurerm_cosmosdb_account
#11597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68 Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍
azurerm/internal/services/cosmos/cosmosdb_account_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_account_resource_test.go
Outdated
Show resolved
Hide resolved
duplicate of #10578 |
backup_policy
in azurerm_cosmosdb_account
backup
in azurerm_cosmosdb_account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.58.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix: #10557
#8507
=== RUN TestAccCosmosDBAccount_backupPolicy
=== PAUSE TestAccCosmosDBAccount_backupPolicy
=== CONT TestAccCosmosDBAccount_backupPolicy
--- PASS: TestAccCosmosDBAccount_backupPolicy (1513.32s)
=== RUN TestAccCosmosDBAccount_backupPolicyContinuous
=== PAUSE TestAccCosmosDBAccount_backupPolicyContinuous
=== CONT TestAccCosmosDBAccount_backupPolicyContinuous
--- PASS: TestAccCosmosDBAccount_backupPolicyContinuous (1031.44s)